[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match gue
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg |
Date: |
Tue, 10 Sep 2013 15:37:12 +0200 |
On Wed, 4 Sep 2013 13:48:29 +0300
"Michael S. Tsirkin" <address@hidden> wrote:
> For Q35, MMCFG address and size are guest configurable.
> Update w32 property to make it behave accordingly.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/pci-host/q35.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> index 4febd24..3f1d447 100644
> --- a/hw/pci-host/q35.c
> +++ b/hw/pci-host/q35.c
> @@ -214,6 +214,16 @@ static void mch_update_pciexbar(MCHPCIState *mch)
> }
> addr = pciexbar & addr_mask;
> pcie_host_mmcfg_update(pehb, enable, addr, length);
> + /* Leave enough space for the MCFG BAR */
> + /*
> + * TODO: this matches current bios behaviour, but it's not a power of
> two,
> + * which means an MTRR can't cover it exactly.
> + */
> + if (enable) {
> + mch->pci_info.w32.begin = addr + length;
> + } else {
> + mch->pci_info.w32.begin = MCH_HOST_BRIDGE_PCIEXBAR_DEFAULT;
> + }
> }
I probably miss something but where is remapping in system address space?
If there is none then, then updated w32 might mismatch actually/initially
mapped alias.
> /* PAM */
- [Qemu-devel] [PATCH 0/6] pci: keep window properties up to date, Michael S. Tsirkin, 2013/09/04
- [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg, Michael S. Tsirkin, 2013/09/04
- Re: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg,
Igor Mammedov <=
- Re: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg, Michael S. Tsirkin, 2013/09/10
- Re: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg, Igor Mammedov, 2013/09/10
- Re: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg, Michael S. Tsirkin, 2013/09/10
- Re: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg, Igor Mammedov, 2013/09/10
- Re: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg, Michael S. Tsirkin, 2013/09/10
- Re: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg, Igor Mammedov, 2013/09/10
- Re: [Qemu-devel] [PATCH 1/6] q35: make pci window address/size match guest cfg, Michael S. Tsirkin, 2013/09/10
[Qemu-devel] [PATCH 2/6] range: add Range to typedefs, Michael S. Tsirkin, 2013/09/04
[Qemu-devel] [PATCH 3/6] range: add min/max operations on ranges, Michael S. Tsirkin, 2013/09/04