[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 0/6] Provide additional info through qemu-img inf
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v3 0/6] Provide additional info through qemu-img info |
Date: |
Tue, 10 Sep 2013 11:33:16 +0200 |
qemu-img info provides only pretty general information about an image.
For any image format, there might be specific options which cannot be
represented in a universal way; for instance, qcow2 provides the
compatibility and lazy_refcount options whose values are certainly
interesting but currently cannot be output by qemu-img info.
Therefore, this series adds a new ImageInfoSpecific union type to
ImageInfo and BlockDriverInfo which may be used by block drivers as a
template for new types dedicated to the specific information they can
provide. It also adds support to qemu-img info and qemu-io -c info to
print the content of these specific structures.
v3:
- implemented Fam's remarks:
- bdrv_get_info already initializes all fields to NULL, no need to do
this manually (patch 2)
- implemented bdrv_put_info as a wrapper to
qapi_free_ImageInfoSpecific, though this may change with further
extensions to BlockDriverInfo (patch 2)
- changed one occurence of puts("foo") to printf("foo\n") in order to
be consistent with the surrounding code (patch 3)
- other patches (1, 4, 5, 6) remain unmodified
v2:
- following Eric's recommendation: changed the representation of the
format specific information from an uninterpreted blobbed string to a
union of format specific types
Max Reitz (6):
qapi: Add ImageInfoSpecific type
block: Add ImageInfoSpecific to BlockDriverInfo
block/qapi: Human-readable ImageInfoSpecific dump
qcow2: Add support for ImageInfoSpecific
qemu-iotests: Discard specific info in _img_info
qemu-iotests: Additional info from qemu-img info
block.c | 16 +++++-
block/mirror.c | 16 ++++--
block/qapi.c | 125 +++++++++++++++++++++++++++++++++++++++++++
block/qcow2.c | 12 +++++
include/block/block.h | 3 ++
include/block/qapi.h | 2 +
qapi-schema.json | 34 +++++++++++-
qemu-img.c | 1 +
qemu-io-cmds.c | 8 +++
tests/qemu-iotests/064 | 72 +++++++++++++++++++++++++
tests/qemu-iotests/064.out | 22 ++++++++
tests/qemu-iotests/common.rc | 19 ++++++-
tests/qemu-iotests/group | 1 +
13 files changed, 323 insertions(+), 8 deletions(-)
create mode 100755 tests/qemu-iotests/064
create mode 100644 tests/qemu-iotests/064.out
--
1.8.3.1
- [Qemu-devel] [PATCH v3 0/6] Provide additional info through qemu-img info,
Max Reitz <=
- [Qemu-devel] [PATCH v3 1/6] qapi: Add ImageInfoSpecific type, Max Reitz, 2013/09/10
- [Qemu-devel] [PATCH v3 2/6] block: Add ImageInfoSpecific to BlockDriverInfo, Max Reitz, 2013/09/10
- [Qemu-devel] [PATCH v3 3/6] block/qapi: Human-readable ImageInfoSpecific dump, Max Reitz, 2013/09/10
- [Qemu-devel] [PATCH v3 4/6] qcow2: Add support for ImageInfoSpecific, Max Reitz, 2013/09/10
- [Qemu-devel] [PATCH v3 6/6] qemu-iotests: Additional info from qemu-img info, Max Reitz, 2013/09/10
[Qemu-devel] [PATCH v3 5/6] qemu-iotests: Discard specific info in _img_info, Max Reitz, 2013/09/10