[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 2/2] hw/mips: use sizes.h macros
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [RFC 2/2] hw/mips: use sizes.h macros |
Date: |
Mon, 9 Sep 2013 19:33:01 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Sep 04, 2013 at 11:35:28AM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <address@hidden>
> ---
> hw/mips/mips_malta.c | 3 ++-
> include/hw/mips/bios.h | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index ae0921c..7e8978b 100644
> --- a/hw/mips/mips_malta.c
> +++ b/hw/mips/mips_malta.c
> @@ -51,6 +51,7 @@
> #include "sysemu/qtest.h"
> #include "qemu/error-report.h"
> #include "hw/empty_slot.h"
> +#include "sizes.h"
>
> //#define DEBUG_BOARD_INIT
>
> @@ -63,7 +64,7 @@
> #define FPGA_ADDRESS 0x1f000000ULL
> #define RESET_ADDRESS 0x1fc00000ULL
>
> -#define FLASH_SIZE 0x400000
> +#define FLASH_SIZE SZ_4M
>
> #define MAX_IDE_BUS 2
>
> diff --git a/include/hw/mips/bios.h b/include/hw/mips/bios.h
> index b4b88ac..e744425 100644
> --- a/include/hw/mips/bios.h
> +++ b/include/hw/mips/bios.h
> @@ -1,6 +1,7 @@
> #include "cpu.h"
> +#include "sizes.h"
>
> -#define BIOS_SIZE (4 * 1024 * 1024)
> +#define BIOS_SIZE SZ_4M
> #ifdef TARGET_WORDS_BIGENDIAN
> #define BIOS_FILENAME "mips_bios.bin"
> #else
Besides the comments from the previous patch:
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net