[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v3 1/2] memory: allow MemoryRegion's priorit
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH RFC v3 1/2] memory: allow MemoryRegion's priority field to accept negative values |
Date: |
Mon, 9 Sep 2013 14:48:55 +0300 |
On Mon, Sep 09, 2013 at 12:45:12PM +0100, Peter Maydell wrote:
> On 9 September 2013 12:41, Michael S. Tsirkin <address@hidden> wrote:
> > On Mon, Sep 09, 2013 at 02:21:35PM +0300, Marcel Apfelbaum wrote:
> >> Priority is used to make visible some subregions by obscuring
> >> the parent MemoryRegion addresses overlapping with the subregion.
> >>
> >> By allowing the priority to be negative the opposite can be done:
> >> Allow a subregion to be visible on all the addresses not covered
> >> by the parent MemoryRegion or other subregions.
> >>
> >> Signed-off-by: Marcel Apfelbaum <address@hidden>
> >
> > Seems harmless enough.
> >
> > Reviewed-by: Michael S. Tsirkin <address@hidden>
>
> No, the idea is good but this version is just broken.
> See the comments I made on the previous version which
> Marcel ignored :-(
>
> -- PMM
You are right, I missed the bugs.
Good catch, thanks.
[Qemu-devel] [PATCH RFC v3 2/2] hw/pci: handle unassigned pci addresses, Marcel Apfelbaum, 2013/09/09