Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

[Alexander Graf]

On 01.08.2013, at 16:12, Jason J. Herne wrote:

> From: "Jason J. Herne" <address@hidden>
> 
> Latest code for cpu Hotplug on S390 architecture.   This one is vastly simpler
> than v2 as we have decided to avoid the command line specification 
> of -device s390-cpu.
> 
> The last version can be found here:
> http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg01183.html
> 
> There is also a patch in this series to add cpu-add to the Qemu monitor
> interface.
> 
> Hotplugged cpus are created in the configured state and can be used by the
> guest after the guest onlines the cpu by: 
> "echo 1 > /sys/bus/cpu/devices/cpuN/online"
> 
> Hot unplugging is currently not implemented by this code. 

Very simple and clean patch set. I don't think it deserves the RFC tag.

Apart from the minor comments I had consider it

Reviewed-by: Alexander Graf <address@hidden>


Alex