Re: [Qemu-devel] [PATCH] exec: check offset_within_address_space for register subpage

[Paolo Bonzini]

Il 29/08/2013 12:21, Hu Tao ha scritto:
> If offset_within_address_space falls in a page, then we register a
> subpage. So check offset_within_address_space rather than
> offset_within_region.
> 
> Cc: Paolo Bonzini <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: "Andreas Färber" <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Blue Swirl <address@hidden>
> Signed-off-by: Hu Tao <address@hidden>
> ---
>  exec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/exec.c b/exec.c
> index 3ca9381..f1f9151 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -869,7 +869,7 @@ static void mem_add(MemoryListener *listener, 
> MemoryRegionSection *section)
>          now = remain;
>          if (int128_lt(remain.size, page_size)) {
>              register_subpage(d, &now);
> -        } else if (remain.offset_within_region & ~TARGET_PAGE_MASK) {
> +        } else if (remain.offset_within_address_space & ~TARGET_PAGE_MASK) {
>              now.size = page_size;
>              register_subpage(d, &now);
>          } else {
> 

Reviewed-by: Paolo Bonzini <address@hidden>