[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] tcg/optimize: fixes and improvements
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] tcg/optimize: fixes and improvements |
Date: |
Tue, 03 Sep 2013 09:21:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 03/09/2013 08:27, Aurelien Jarno ha scritto:
> This patchset first fixes known-zero bits optimization so that it is
> actually used, and does some further optimizations for 32-bit ops and
> unsigned loads.
>
> Aurelien Jarno (4):
> tcg/optimize: fix know-zero bits optimization
> tcg/optimize: fix known-zero bits for right shift ops
> tcg/optimize: improve known-zero bits for 32-bit ops
> tcg/optimize: add known-zero bits compute for load ops
>
> tcg/optimize.c | 48 +++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 43 insertions(+), 5 deletions(-)
>
Commit message 1 is a bit misleading, because the optimization still
works for quite a few cases involving constant and copy propagation.
However, I had the same patch in my queue, so I can't deny that there is
a problem. :)
Two questions:
1) should patch 2 be CCed to qemu-stable?
2) should patches 1 and 2 be inverted to avoid triggering bugs?
Paolo
- [Qemu-devel] [PATCH 0/4] tcg/optimize: fixes and improvements, Aurelien Jarno, 2013/09/03
- [Qemu-devel] [PATCH 2/4] tcg/optimize: fix known-zero bits for right shift ops, Aurelien Jarno, 2013/09/03
- [Qemu-devel] [PATCH 4/4] tcg/optimize: add known-zero bits compute for load ops, Aurelien Jarno, 2013/09/03
- [Qemu-devel] [PATCH 1/4] tcg/optimize: fix know-zero bits optimization, Aurelien Jarno, 2013/09/03
- [Qemu-devel] [PATCH 3/4] tcg/optimize: improve known-zero bits for 32-bit ops, Aurelien Jarno, 2013/09/03
- Re: [Qemu-devel] [PATCH 0/4] tcg/optimize: fixes and improvements,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 0/4] tcg/optimize: fixes and improvements, Richard Henderson, 2013/09/03