Re: [Qemu-devel] [PATCH RFC 3/3] hw/pci-host: catch acesses to unassigned pci addresses

[Peter Maydell]

On 2 September 2013 15:13, Marcel Apfelbaum <address@hidden> wrote:
> Added a memory region that has negative priority and
> extends over all the pci adddress space. This region will
> "catch" all the accesses to the unassigned pci
> addresses and it will be possible to emulate the
> master abort scenario (When no device on the bus claims
> the transaction).
>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
>  hw/pci-host/piix.c        |  8 ++++++++
>  hw/pci-host/q35.c         | 19 ++++++++++++++++---
>  include/hw/pci-host/q35.h |  1 +

This is happening at the wrong layer -- you want this memory
region to be created and managed in the PCI core code so that
we get correct PCI-spec behaviour for all our PCI controllers,
not just the two x86 ones you've changed here.

-- PMM