[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/9] char: introduce tcp_chr_detach()
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 2/9] char: introduce tcp_chr_detach() |
Date: |
Wed, 28 Aug 2013 09:09:47 +0200 |
Hi,
> +static void tcp_chr_detach(CharDriverState *chr)
> +{
> + TCPCharDriver *s = chr->opaque;
> +
> + if (s->tag) {
> + io_remove_watch_poll(s->tag);
> + s->tag = 0;
> + }
> +}
Lots of simliar functions in the other patches.
Doesn't it make sense to move the tag field from TCPCharDriver to
CharDriverState instead, so we don't need a new callback in the first
place?
cheers,
Gerd
- [Qemu-devel] [PATCH 0/9] char: fix segfault on chardev detach, Amit Shah, 2013/08/28
- [Qemu-devel] [PATCH 3/9] char: introduce fd_chr_detach(), Amit Shah, 2013/08/28
- [Qemu-devel] [PATCH 4/9] char: introduce pty_chr_detach(), Amit Shah, 2013/08/28
- [Qemu-devel] [PATCH 5/9] char: introduce udp_chr_detach(), Amit Shah, 2013/08/28
- [Qemu-devel] [PATCH 6/9] char: use the new fd_chr_detach to dedup code, Amit Shah, 2013/08/28
- [Qemu-devel] [PATCH 7/9] char: use the new pty_chr_detach to dedup code, Amit Shah, 2013/08/28
- [Qemu-devel] [PATCH 8/9] char: use the new udp_chr_detach to dedup code, Amit Shah, 2013/08/28
- [Qemu-devel] [PATCH 9/9] char: use the new tcp_chr_detach to dedup code, Amit Shah, 2013/08/28