Re: [Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects depending on CLIPPER

[Paolo Bonzini]

Il 26/08/2013 16:41, Richard Henderson ha scritto:
> On 08/25/2013 03:58 PM, Ákos Kovács wrote:
>> Set CONFIG_CLIPPER as default for default-configs/alpha-softmmu.mak
>>
>> Signed-off-by: Ákos Kovács <address@hidden>
>> ---
>>  default-configs/alpha-softmmu.mak |    2 ++
>>  hw/alpha/Makefile.objs            |    2 +-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/default-configs/alpha-softmmu.mak 
>> b/default-configs/alpha-softmmu.mak
>> index bc07600..1e8bbff 100644
>> --- a/default-configs/alpha-softmmu.mak
>> +++ b/default-configs/alpha-softmmu.mak
>> @@ -15,3 +15,5 @@ CONFIG_IDE_CMD646=y
>>  CONFIG_I8259=y
>>  CONFIG_MC146818RTC=y
>>  CONFIG_ISA_TESTDEV=y
>> +
>> +CONFIG_CLIPPER=y
>> diff --git a/hw/alpha/Makefile.objs b/hw/alpha/Makefile.objs
>> index 5c74275..0a6ade5 100644
>> --- a/hw/alpha/Makefile.objs
>> +++ b/hw/alpha/Makefile.objs
>> @@ -1 +1 @@
>> -obj-y += dp264.o pci.o typhoon.o
>> +obj-$(CONFIG_CLIPPER) += dp264.o pci.o typhoon.o
>>
> 
> I don't understand the point of this.  There is one alpha emulation;
> if you disable it you're left with a program that's not useful.  So
> why the configuration for it at all?

I think this was just for consistency with other targets.  Either this
patch can be left out completely, or the symbol can be made default on
and unchangeable by the user.

Paolo