Re: [Qemu-devel] [PATCH 31/47] hw/isa/Kconfig: Add Kconfig file

[Paolo Bonzini]

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <address@hidden>
> ---
>  hw/isa/Kconfig |   42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 hw/isa/Kconfig
> 
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> new file mode 100644
> index 0000000..8b6baaf
> --- /dev/null
> +++ b/hw/isa/Kconfig
> @@ -0,0 +1,42 @@
> +#config ISA
> +#   bool

Why is it commented out?

> +config APM
> +    bool
> +
> +config I82378
> +    bool    
> +    #select ISA
> +    select I8259  # irq
> +    select PCSPK
> +    select I82374 # DMA
> +    select MC146818RTC # timer
> +    depends on PCI
> +
> +config ISA_MMIO
> +    bool
> +    #select ISA 

This doesn't exist anymore.

> +config PC87312
> +    bool
> +    #select ISA 
> +    select SERIAL
> +    select PARALLEL
> +    select FDC
> +    select IDE_ISA
> +
> +config PIIX4
> +    bool
> +    #select ISA 
> +    depends on PCI
> +
> +config VT82C686
> +    bool
> +    #select ISA 
> +    depends on PCI
> +
> +config LPC_ICH9
> +    bool
> +    #select ISA 
> +    depends on PCI 
> +    select APM

"select ISA" is right for this file.

Paolo