qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 1/3] pci: remove explicit check to 64K ioport size


From: Hervé Poussineau
Subject: [Qemu-devel] [PATCH 1/3] pci: remove explicit check to 64K ioport size
Date: Fri, 23 Aug 2013 20:52:51 +0200

This check is useless, as bigger addresses will be ignored when
added to 'io' MemoryRegion, which has a size of 64K.

However, on architectures which have memory-mapped I/O, PCI I/O BARs
can be mapped to an I/O address which is bigger than 64K.

Signed-off-by: Hervé Poussineau <address@hidden>
---
 hw/pci/pci.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 4c004f5..54cd43d 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1033,8 +1033,7 @@ static pcibus_t pci_bar_address(PCIDevice *d,
         }
         new_addr = pci_get_long(d->config + bar) & ~(size - 1);
         last_addr = new_addr + size - 1;
-        /* NOTE: we have only 64K ioports on PC */
-        if (last_addr <= new_addr || new_addr == 0 || last_addr > UINT16_MAX) {
+        if (last_addr <= new_addr || new_addr == 0) {
             return PCI_BAR_UNMAPPED;
         }
         return new_addr;
-- 
1.7.10.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]