[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Make usb-bt-dongle configurable
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] Make usb-bt-dongle configurable |
Date: |
Mon, 19 Aug 2013 16:19:17 +0200 |
On Mo, 2013-08-19 at 15:58 +0200, Paolo Bonzini wrote:
> Il 19/08/2013 15:41, Andreas Färber ha scritto:
> > By my reading of `git grep CONFIG_USB_BLUETOOTH` it isn't disappearing,
> > check default-configs/usb.mak. All targets that include usb.mak will
> > have CONFIG_USB_BLUETOOTH.
> >
> > It's only used in the build system and with this patch in vl.c, so
> > assuming that Miroslav has checked that the build succeeds for all
> > targets, this should be fine, I guess.
>
> Actually, CONFIG_* symbols for devices are _not_ exposed to vl.c. Blue
> Swirl specifically wanted that to happen. So I'm afraid Mirek's patch
> breaks "-usb bt" even if CONFIG_USB_BLUETOOTH is set to y.
"-usbdevice bt", to be exact.
I'd suggest to switch bluetooth over to use usb_legacy_register() to
parse+handle the legacy -usbdevice cmd line option and zap the vl.c
dependency this way.
cheers,
Gerd
Re: [Qemu-devel] [PATCH] Make usb-bt-dongle configurable, Paolo Bonzini, 2013/08/19