[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.6 v2 2/2] pci-bridge: Move common class in
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.6 v2 2/2] pci-bridge: Move common class initializations to base type |
|
Date: |
Mon, 05 Aug 2013 18:22:18 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 05.08.2013 16:41, schrieb Paolo Bonzini:
> On 08/05/2013 04:36 PM, Andreas Färber wrote:
>> Set PCIDeviceClass::is_bridge as well as PCIDeviceClass::config_write(),
>> PCIDeviceClass::exit() and DeviceClass::reset() defaults directly for
>> TYPE_PCI_BRIDGE (complements f055e96bd4311d287c0e03faec02a1bdbc351925).
>>
>> This avoids another pci_bridge_config_write() missing somewhere, unless
>> explicitly overridden.
>>
>> Reported-by: Gerd Hoffmann <address@hidden>
>> Signed-off-by: Andreas Färber <address@hidden>
>
> Why for 1.6?
This is The Real Fix. We could squash it as one patch, but then we can't
backport it.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg