[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/7] vvfat: use bdrv_new() to allocate BlockD
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/7] vvfat: use bdrv_new() to allocate BlockDriverState |
Date: |
Fri, 02 Aug 2013 15:23:30 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Reviewed-by: Wenchao Xia <address@hidden>
> we need bdrv_new() to properly initialize BDS, don't allocate memory
> manually.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/vvfat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index cd3b8ed..a827d91 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -2943,7 +2943,7 @@ static int enable_write_target(BDRVVVFATState *s)
> unlink(s->qcow_filename);
> #endif
>
> - s->bs->backing_hd = calloc(sizeof(BlockDriverState), 1);
> + s->bs->backing_hd = bdrv_new("");
> s->bs->backing_hd->drv = &vvfat_write_target;
> s->bs->backing_hd->opaque = g_malloc(sizeof(void*));
> *(void**)s->bs->backing_hd->opaque = s;
>
--
Best Regards
Wenchao Xia
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 1/7] vvfat: use bdrv_new() to allocate BlockDriverState,
Wenchao Xia <=