[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 09/10] qemu-ga: Install Windows VSS provider
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v8 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install' |
Date: |
Tue, 30 Jul 2013 15:20:15 -0500 |
User-agent: |
alot/0.3.4 |
Quoting Tomoki Sekiyama (2013-07-23 17:46:03)
> Register QGA VSS provider library into Windows when qemu-ga is installed as
> Windows service ('-s install' option). It is deregistered when the service
> is uninstalled ('-s uninstall' option).
>
> Signed-off-by: Tomoki Sekiyama <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
> ---
> qga/main.c | 10 +++++++++-
> qga/vss-win32.c | 25 +++++++++++++++++++++++++
> qga/vss-win32.h | 3 +++
> 3 files changed, 37 insertions(+), 1 deletion(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index 0e04e73..6c746c8 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -34,6 +34,7 @@
> #include "qemu/bswap.h"
> #ifdef _WIN32
> #include "qga/service-win32.h"
> +#include "qga/vss-win32.h"
> #include <windows.h>
> #endif
> #ifdef __linux__
> @@ -1031,8 +1032,15 @@ int main(int argc, char **argv)
> fixed_state_dir = (state_dir == dfl_pathnames.state_dir) ?
> NULL :
> state_dir;
> - return ga_install_service(path, log_filepath,
> fixed_state_dir);
> + if (ga_install_vss_provider()) {
> + return EXIT_FAILURE;
> + }
> + if (ga_install_service(path, log_filepath, fixed_state_dir))
> {
> + return EXIT_FAILURE;
> + }
> + return 0;
> } else if (strcmp(service, "uninstall") == 0) {
> + ga_uninstall_vss_provider();
> return ga_uninstall_service();
> } else {
> printf("Unknown service command.\n");
> diff --git a/qga/vss-win32.c b/qga/vss-win32.c
> index ef5f0df..7b77a8c 100644
> --- a/qga/vss-win32.c
> +++ b/qga/vss-win32.c
> @@ -119,6 +119,31 @@ bool vss_initialized(void)
> return !!provider_lib;
> }
>
> +int ga_install_vss_provider(void)
> +{
> + HRESULT hr;
> +
> + if (!vss_init(false)) {
> + fprintf(stderr, "Installation of VSS provider is skipped. "
> + "fsfreeze will be disabled.\n");
> + return 0;
> + }
> + hr = call_vss_provider_func("COMRegister");
> + vss_deinit(false);
> +
> + return SUCCEEDED(hr) ? 0 : EXIT_FAILURE;
> +}
> +
> +void ga_uninstall_vss_provider(void)
> +{
> + if (!vss_init(false)) {
> + fprintf(stderr, "Removal of VSS provider is skipped.\n");
> + return;
> + }
> + call_vss_provider_func("COMUnregister");
> + vss_deinit(false);
> +}
> +
> /* Call VSS requester and freeze/thaw filesystems and applications */
> void qga_vss_fsfreeze(int *nr_volume, Error **err, bool freeze)
> {
> diff --git a/qga/vss-win32.h b/qga/vss-win32.h
> index eac669c..db8fbe5 100644
> --- a/qga/vss-win32.h
> +++ b/qga/vss-win32.h
> @@ -19,6 +19,9 @@ bool vss_init(bool init_requester);
> void vss_deinit(bool deinit_requester);
> bool vss_initialized(void);
>
> +int ga_install_vss_provider(void);
> +void ga_uninstall_vss_provider(void);
> +
> void qga_vss_fsfreeze(int *nr_volume, Error **err, bool freeze);
>
> #endif
- [Qemu-devel] [PATCH v8 00/10] qemu-ga: fsfreeze on Windows using VSS, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 01/10] configure: Support configuring C++ compiler, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 02/10] Add c++ keywords to QAPI helper script, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 03/10] checkpatch.pl: Check .cpp files, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 04/10] Add a script to extract VSS SDK headers on POSIX system, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 06/10] error: Add error_set_win32 and error_setg_win32, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Tomoki Sekiyama, 2013/07/23
- Re: [Qemu-devel] [PATCH v8 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install',
Michael Roth <=
- [Qemu-devel] [PATCH v8 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL, Tomoki Sekiyama, 2013/07/23