[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type p
From: |
Michal Novotny |
Subject: |
Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided |
Date: |
Tue, 30 Jul 2013 17:30:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
Hi Markus,
should I rebase it or no need and can maintainer do it before push?
Michal
On 07/30/2013 05:17 PM, Markus Armbruster wrote:
> Michal Novotny <address@hidden> writes:
>
>> Output error message when user provides the invalid machine type
>> on the command line. This also saves time to find what issue is
>> when you upgrade from one version of qemu to another version that
>> doesn't support required machine type any longer.
> Text from here
>
>> The patch is checked using ./scripts/checkpatch.pl script and
>> also is_help_option() function is being used.
>>
>> Michal
> to here belongs below the '---' line, so it's ommitted from the commit
> message.
>
>> Signed-off-by: Michal Novotny <address@hidden>
>> ---
>> vl.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 25b8f2f..563ae67 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name)
>> if (machine) {
>> return machine;
>> }
>> +
>> + if (name && !is_help_option(name)) {
>> + printf("Error: Unsupported machine type '%s'\n", name);
>> + }
>> +
>> printf("Supported machines are:\n");
>> for (m = first_machine; m != NULL; m = m->next) {
>> if (m->alias) {
--
Michal Novotny <address@hidden>, RHCE, Red Hat
Virtualization | libvirt-php bindings | php-virt-control.org