[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2] migration: don't use uninitialized variables
From: |
Pawit Pornkitprasan |
Subject: |
[Qemu-devel] [PATCH v2] migration: don't use uninitialized variables |
Date: |
Tue, 30 Jul 2013 08:39:52 +0900 |
The qmp_migrate method uses the 'blk' and 'inc' parameter without
checking if they're valid or not (they may be uninitialized if
command is received via QMP)
Signed-off-by: Pawit Pornkitprasan <address@hidden>
---
migration.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration.c b/migration.c
index 9fc7294..57a7998 100644
--- a/migration.c
+++ b/migration.c
@@ -399,8 +399,8 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,
MigrationParams params;
const char *p;
- params.blk = blk;
- params.shared = inc;
+ params.blk = has_blk && blk;
+ params.shared = has_inc && inc;
if (s->state == MIG_STATE_ACTIVE || s->state == MIG_STATE_SETUP) {
error_set(errp, QERR_MIGRATION_ACTIVE);
--
1.7.3.4
- [Qemu-devel] [PATCH v2] migration: don't use uninitialized variables,
Pawit Pornkitprasan <=