[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence for SU
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence for SUNW, fdtwo |
|
Date: |
Mon, 29 Jul 2013 14:15:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 29.07.2013 13:55, schrieb Mark Cave-Ayland:
> On 27/07/13 02:50, Andreas Färber wrote:
>
>> Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's
>> initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539)
>> was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than
>> SUNW,fdtwo.
>>
>> Fix this by letting SUNW,fdtwo and sysbus-fdc both inherit from an
>> abstract type base-sysbus-fdc.
>>
>> This allows to consolidate realizefns by using instance_init functions.
>> Clean up variable names and variable order while at it.
>>
>> Reported-by: Mark Cave-Ayland<address@hidden>
>> Cc: Hu Tao<address@hidden>
>> Signed-off-by: Andreas Färber<address@hidden>
>
> Hi Andreas,
>
> I can confirm that this fixes SPARC32 for me - thanks!
>
> Tested-by: Mark Cave-Ayland <address@hidden>
Thanks. Can you give my latest qom-devices branch a whirl, too?
I started adding trivial qtests for machines, but only covering the
default machines without -fda etc.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg