[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 14/18] block/ssh: drop return_true()
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCH v6 14/18] block/ssh: drop return_true() |
Date: |
Mon, 29 Jul 2013 16:25:22 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Reviewed-by: Wenchao Xia <address@hidden>
> .io_flush() is no longer called so drop return_true().
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block/ssh.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/block/ssh.c b/block/ssh.c
> index d7e7bf8..e149da9 100644
> --- a/block/ssh.c
> +++ b/block/ssh.c
> @@ -740,14 +740,6 @@ static void restart_coroutine(void *opaque)
> qemu_coroutine_enter(co, NULL);
> }
>
> -/* Always true because when we have called set_fd_handler there is
> - * always a request being processed.
> - */
> -static int return_true(void *opaque)
> -{
> - return 1;
> -}
> -
> static coroutine_fn void set_fd_handler(BDRVSSHState *s)
> {
> int r;
> @@ -766,7 +758,7 @@ static coroutine_fn void set_fd_handler(BDRVSSHState *s)
> DPRINTF("s->sock=%d rd_handler=%p wr_handler=%p", s->sock,
> rd_handler, wr_handler);
>
> - qemu_aio_set_fd_handler(s->sock, rd_handler, wr_handler, return_true,
> co);
> + qemu_aio_set_fd_handler(s->sock, rd_handler, wr_handler, NULL, co);
> }
>
> static coroutine_fn void clear_fd_handler(BDRVSSHState *s)
>
--
Best Regards
Wenchao Xia
- [Qemu-devel] [PATCH v6 18/18] aio: drop io_flush argument, (continued)
- [Qemu-devel] [PATCH v6 18/18] aio: drop io_flush argument, Stefan Hajnoczi, 2013/07/25
- [Qemu-devel] [PATCH v6 11/18] block/nbd: drop nbd_have_request(), Stefan Hajnoczi, 2013/07/25
- [Qemu-devel] [PATCH v6 04/18] tests: adjust test-aio to new aio_poll() semantics, Stefan Hajnoczi, 2013/07/25
- [Qemu-devel] [PATCH v6 16/18] thread-pool: drop thread_pool_active(), Stefan Hajnoczi, 2013/07/25
- [Qemu-devel] [PATCH v6 12/18] block/rbd: drop qemu_rbd_aio_flush_cb(), Stefan Hajnoczi, 2013/07/25
- [Qemu-devel] [PATCH v6 14/18] block/ssh: drop return_true(), Stefan Hajnoczi, 2013/07/25
- Re: [Qemu-devel] [PATCH v6 14/18] block/ssh: drop return_true(),
Wenchao Xia <=
- [Qemu-devel] [PATCH v6 10/18] block/linux-aio: drop qemu_laio_completion_cb(), Stefan Hajnoczi, 2013/07/25
- [Qemu-devel] [PATCH v6 13/18] block/sheepdog: drop have_co_req() and aio_flush_request(), Stefan Hajnoczi, 2013/07/25
- [Qemu-devel] [PATCH v6 09/18] block/iscsi: drop iscsi_process_flush(), Stefan Hajnoczi, 2013/07/25
- [Qemu-devel] [PATCH v6 07/18] block/curl: drop curl_aio_flush(), Stefan Hajnoczi, 2013/07/25
- [Qemu-devel] [PATCH v6 05/18] tests: adjust test-thread-pool to new aio_poll() semantics, Stefan Hajnoczi, 2013/07/25