[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state |
Date: |
Sun, 28 Jul 2013 15:51:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
Il 28/07/2013 14:57, Gleb Natapov ha scritto:
>> @@ -1114,6 +1135,33 @@ static int kvm_put_msrs(X86CPU *cpu, int level)
>> kvm_msr_entry_set(&msrs[n++], MSR_KVM_STEAL_TIME,
>> env->steal_time_msr);
>> }
>> + if (has_msr_architectural_pmu) {
>> + /* Stop the counter. */
>> + kvm_msr_entry_set(&msrs[n++], MSR_CORE_PERF_FIXED_CTR_CTRL, 0);
>> + kvm_msr_entry_set(&msrs[n++], MSR_CORE_PERF_GLOBAL_CTRL, 0);
>> +
> Why is this needed?
In v1 it was in the commit message. I'll fix it up before applying:
> Second, to avoid any possible side effects during the setting of MSRs
> I stop the PMU while setting the counters and event selector MSRs.
> Stopping the PMU snapshots the counters and ensures that no strange
> races can happen if the counters were saved close to their overflow
> value.
Paolo
Re: [Qemu-devel] [PATCH v2 0/2] kvm: migrate vPMU state, Andreas Färber, 2013/07/28