Re: [Qemu-devel] [PATCH RFC qom-next 0/4] QOM'ification of pci-bridge types

[Andreas Färber]

Am 21.07.2013 22:26, schrieb Michael S. Tsirkin:
> On Sun, Jul 21, 2013 at 04:09:00PM +0200, Andreas Färber wrote:
>> Hello Michael et al.,
>>
>> This series turns PCIBridge, PCIEPort and PCIESlot into abstract QOM types,
>> so that we can use QOM casts to obtain a pointer.
>>
>> Possibly this was prompted by q35's PCIe?
> 
> What was prompted?

This refactoring series.

> What's the question exactly?

Why I prepared this series on an offline train ride on Wednesday. ;) Not
for you to answer - something PCIe must've gotten in the way of some QOM
realize conversion but the branch is missing the final patch showing
what these types and casts are good for. Since we're in Soft Freeze I
rather wanted to flush my queues for review though rather than spend
more time puzzling why I did this. :)

Andreas

> 
>> Don't remember ATM...
>>
>> Regards,
>> Andreas
>>
>> Cc: Anthony Liguori <address@hidden>
>> Cc: Paolo Bonzini <address@hidden>
>> Cc: Michael S. Tsirkin <address@hidden>
>> Cc: Peter Crosthwaite <address@hidden>
>> Cc: Hu Tao <address@hidden>
>>
>> Andreas Färber (4):
>>   pci-bridge: Turn into abstract QOM type
>>   pci-bridge-dev: QOM parent field cleanup
>>   pci-bridge/i82801b11: Rename parent field
>>   pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types
>>
>>  hw/pci-bridge/dec.c                |  4 ++--
>>  hw/pci-bridge/i82801b11.c          | 10 ++++++----
>>  hw/pci-bridge/ioh3420.c            | 29 +++++++++++++--------------
>>  hw/pci-bridge/pci_bridge_dev.c     | 26 +++++++++++++++----------
>>  hw/pci-bridge/xio3130_downstream.c | 29 +++++++++++++--------------
>>  hw/pci-bridge/xio3130_upstream.c   | 20 +++++++++----------
>>  hw/pci-host/apb.c                  |  4 ++--
>>  hw/pci/pci_bridge.c                | 40 
>> +++++++++++++++++++++++++++-----------
>>  hw/pci/pcie.c                      |  2 +-
>>  hw/pci/pcie_port.c                 | 22 +++++++++++++++++++++
>>  include/hw/pci/pci_bus.h           |  7 ++++++-
>>  include/hw/pci/pcie_port.h         | 14 +++++++++++--
>>  12 files changed, 132 insertions(+), 75 deletions(-)
>>
>> -- 
>> 1.8.1.4
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg