[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu v2 01/42] cpu: Introduce vaddr type
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu v2 01/42] cpu: Introduce vaddr type |
Date: |
Mon, 22 Jul 2013 16:48:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 15.07.2013 16:46, schrieb Peter Maydell:
> On 7 July 2013 19:25, Andreas Färber <address@hidden> wrote:
>> vaddr is to target_ulong what uintmax_t is to unsigned int.
>>
>> Its purpose is to allow turning per-target functions with target_ulong
>> arguments into CPUClass hooks.
>>
>> Suggested-by: Peter Maydell <address@hidden>
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>> include/qom/cpu.h | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
>> index 147c256..4fd12a0 100644
>> --- a/include/qom/cpu.h
>> +++ b/include/qom/cpu.h
>> @@ -29,6 +29,14 @@
>>
>> typedef int (*WriteCoreDumpFunction)(void *buf, size_t size, void *opaque);
>>
>> +typedef uint64_t vaddr;
>> +#define VADDR_PRId PRId64
>> +#define VADDR_PRIu PRIu64
>> +#define VADDR_PRIo PRIo64
>> +#define VADDR_PRIx PRIx64
>> +#define VADDR_PRIX PRIX64
>> +#define VADDR_MAX UINT64_MAX
>> +
>
> This looks OK, but I think it could use a brief comment above
> the typedef explaining its purpose, and an update to HACKING
> to say when to use vaddr and when target_ulong.
I've added a gtk-doc comment. Not sure about HACKING, that can still be
done as fully reviewed follow-up.
(Note that v3 was identical to the above.)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH qom-cpu v2 00/42] QOM CPUState, part 11: GDB stub, Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 01/42] cpu: Introduce vaddr type, Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 04/42] target-moxie: Implement CPUClass::set_pc(), Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 03/42] target-m68k: Implement CPUClass::set_pc(), Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 05/42] target-unicore32: Implement CPUClass::set_pc(), Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 02/42] cpu: Introduce CPUClass::set_pc() for gdb_set_cpu_pc(), Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 08/42] gdbstub: Update gdb_handlesig() and gdb_signalled() Coding Style, Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 09/42] cpu: Change cpu_single_step() argument to CPUState, Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 11/42] gdbstub: Change syscall callback argument to CPUState, Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 10/42] kvm: Change kvm_{insert, remove}_breakpoint() argument to CPUState, Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 06/42] cpu: Introduce CPUClass::synchronize_from_tb() for cpu_pc_from_tb(), Andreas Färber, 2013/07/07
- [Qemu-devel] [PATCH qom-cpu v2 14/42] gdbstub: Change gdb_{read, write}_register() argument to CPUState, Andreas Färber, 2013/07/07