[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name |
Date: |
Mon, 22 Jul 2013 12:37:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 22.07.2013 11:43, schrieb Peter Maydell:
> On 22 July 2013 10:42, Jia Liu <address@hidden> wrote:
>> Hi Andreas and Peter,
>>
>> On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell <address@hidden> wrote:
>>> This looks a bit odd. The commit message suggests it's an
>>> attempt to fix the bug that was fixed by commit 071b3364e --
>>> is it really needed? Andreas?
>>
>> commit 071b3364e fix the typename only, but this one make "-cpu any"
>> "-cpu or1200" "-cpu any-or32-cpu" "-cpu or1200-or32-cpu" working fine.
>
> The last two of these would be wrong: -cpu should only
> accept CPU names, ie "any" or "or1200".
Peter, the story is that due to an oversight on my part, it was possible
to use -cpu or1200-or32-cpu only for some weeks or months. This has been
fixed so that only -cpu or1200 works.
It is up to Jia whether he sees a need to have both work or whether -cpu
or1200 would be sufficient. In any case, I was not CC'ed on this series,
so I only came across one patch by accident during a search for
something else. ;)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v3 3/4] target-openrisc: Free typename, (continued)
- [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Jia Liu, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Peter Maydell, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Jia Liu, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Peter Maydell, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Jia Liu, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Jia Liu, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Peter Maydell, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Andreas Färber, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Peter Maydell, 2013/07/22
- Re: [Qemu-devel] -cpu behavior (was: [PATCH v3 4/4] target-openrisc: Fix cpu_model by name), Andreas Färber, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Andreas Färber, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Anthony Liguori, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Peter Maydell, 2013/07/22
- Re: [Qemu-devel] -cpu behavior (was: [PATCH v3 4/4] target-openrisc: Fix cpu_model by name), Andreas Färber, 2013/07/22
- Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name, Anthony Liguori, 2013/07/22