[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options |
Date: |
Mon, 22 Jul 2013 14:07:15 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 07/17 14:36, Paolo Bonzini wrote:
> Il 17/07/2013 11:42, Fam Zheng ha scritto:
> > This option allows overriding backing hd of drive. If the target drive
> > exists, it's referenced as the backing file and refcount incremented.
> >
> > Example:
> > qemu-system-x86_64 -drive \
> > file.filename=foo.qcow2,if=none,id=foo \
> > -drive file=bar.qcow2,backing=foo
>
> I guess this is where we need the soft reference.
>
> This has a _lot_ of potential for misuse, I think Kevin bashed me and
> Federico very heavily when we tried to do something similar.
>
> block/backup.c is the right place where we can override the backing hd
> of the drive. Perhaps we can add a way to open a file with
> BDRV_O_NO_BACKING from the command line.
OK. If we get the override in block/backup.c, the only thing we need is
naming the target so we can add it to nbd server. If refcounting,
overriding backing with option and blockdev-backup are still good to
have, I can split them and targeting to future releases.
--
Fam
- [Qemu-devel] [PATCH v2 09/11] block: add assertion to check refcount before deleting, (continued)
- [Qemu-devel] [PATCH v2 09/11] block: add assertion to check refcount before deleting, Fam Zheng, 2013/07/17
- [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Fam Zheng, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Kevin Wolf, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Kevin Wolf, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Kevin Wolf, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Ian Main, 2013/07/23
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Ian Main, 2013/07/23
[Qemu-devel] [PATCH v2 11/11] qmp: add command 'blockdev-backup', Fam Zheng, 2013/07/17
Re: [Qemu-devel] [PATCH v2 00/11] Point-in-time snapshot exporting over NBD, Wenchao Xia, 2013/07/19