[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices |
|
Date: |
Fri, 19 Jul 2013 12:24:10 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jul 18, 2013 at 02:52:19PM +0200, Kevin Wolf wrote:
> Even if the VM is already stopped, we cannot assume that all data has
> already been successfully flushed to disk. The flush during the previous
> vm_stop() could have failed.
>
> Run bdrv_flush_all() unconditionally so that we get an error each time
> if the block device isn't really flushed.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> cpus.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan