[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 06/13] linux-user: Enable NPTL for OpenRISC
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH v3 06/13] linux-user: Enable NPTL for OpenRISC |
Date: |
Tue, 16 Jul 2013 18:44:53 +0100 |
The OpenRISC kernel ignores CLONE_SETTLS in its copy_thread()
implementation, so a cpu_set_tls() implementation is a no-op.
cpu_clone_regs() was setting the syscall return value in the
wrong register -- it is gpr[11], not gpr[2]. With these two
things fixed, we can compile with NPTL enabled.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Jia Liu <address@hidden>
---
configure | 1 -
linux-user/openrisc/target_cpu.h | 9 +++++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 4a241e0..3848c1c 100755
--- a/configure
+++ b/configure
@@ -4229,7 +4229,6 @@ case "$target_name" in
or32)
TARGET_ARCH=openrisc
TARGET_BASE_ARCH=openrisc
- target_nptl="no"
;;
ppc)
gdb_xml_files="power-core.xml power-fpu.xml power-altivec.xml
power-spe.xml"
diff --git a/linux-user/openrisc/target_cpu.h b/linux-user/openrisc/target_cpu.h
index 501fb81..32a46ac 100644
--- a/linux-user/openrisc/target_cpu.h
+++ b/linux-user/openrisc/target_cpu.h
@@ -25,9 +25,14 @@ static inline void cpu_clone_regs(CPUOpenRISCState *env,
target_ulong newsp)
if (newsp) {
env->gpr[1] = newsp;
}
- env->gpr[2] = 0;
+ env->gpr[11] = 0;
}
-/* TODO: need to implement cpu_set_tls() */
+static inline void cpu_set_tls(CPUOpenRISCState *env, target_ulong newtls)
+{
+ /* Linux kernel 3.10 does not pay any attention to CLONE_SETTLS
+ * in copy_thread(), so QEMU need not do so either.
+ */
+}
#endif
--
1.7.9.5
- [Qemu-devel] [PATCH v3 00/13] linux-user: enable NPTL on everything, Peter Maydell, 2013/07/16
- [Qemu-devel] [PATCH v3 12/13] linux-user: Enable NPTL for x86-64, Peter Maydell, 2013/07/16
- [Qemu-devel] [PATCH v3 03/13] configure: Enable threading on all ppc and mips linux-user targets, Peter Maydell, 2013/07/16
- [Qemu-devel] [PATCH v3 06/13] linux-user: Enable NPTL for OpenRISC,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 05/13] linux-user: Move includes of target-specific headers to end of qemu.h, Peter Maydell, 2013/07/16
- [Qemu-devel] [PATCH v3 08/13] linux-user: Enable NPTL for m68k, Peter Maydell, 2013/07/16
- [Qemu-devel] [PATCH v3 01/13] configure: Flip default of target_nptl, Peter Maydell, 2013/07/16
- [Qemu-devel] [PATCH v3 11/13] linux-user: Add i386 TLS setter, Peter Maydell, 2013/07/16
- [Qemu-devel] [PATCH v3 02/13] configure: Don't say target_nptl="no" if there is no linux-user target, Peter Maydell, 2013/07/16
- [Qemu-devel] [PATCH v3 10/13] linux-user: Clean up handling of clone() argument order, Peter Maydell, 2013/07/16
- [Qemu-devel] [PATCH v3 07/13] linux-user: Enable NPTL for SPARC targets, Peter Maydell, 2013/07/16
- [Qemu-devel] [PATCH v3 09/13] linux-user: Add missing 'break' in i386 get_thread_area syscall, Peter Maydell, 2013/07/16