|
From: | Qiao Nuohan |
Subject: | Re: [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages |
Date: | Tue, 16 Jul 2013 11:40:47 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120607 Thunderbird/10.0.5 |
Thanks for your comments! On 07/16/2013 10:43 AM, Stefan Hajnoczi wrote:
@@ -130,6 +139,13 @@ typedef struct DataCache { > off_t offset; /* offset of the file */ > } DataCache; > > +typedef struct PageDesc { > + off_t offset; /* the offset of the page data*/The guest may be 32-bit or 64-bit, independently of the QEMU host wordsize. Is off_t correct when running a 64-bit guest on a 32-bit host? I guess you are assuming off_t == uint64_t here?
The 'offset' should be 64-bit in kdump format both on 32-bit and 64-bit. And I will avoid using off_t in structure used by kdump format. Thanks for pointing it out. -- Regards Qiao Nuohan
[Prev in Thread] | Current Thread | [Next in Thread] |