Re: [Qemu-devel] [PATCH V3 0/2] Implement sync modes for drive-backup.

[Paolo Bonzini]

Il 15/07/2013 20:01, Ian Main ha scritto:
> This patch adds sync modes on top of the work that Stefan Hajnoczi has done.
> 
> These patches apply on kevin/block with 
> '[PATCH] block: add drive_backup HMP command' also applied.
> 
> Hopefully all is in order as this is my first QEMU patch.  Many thanks to 
> Stephan and Fam Zheng for their help.
> 
> V2:
> 
> - No longer poll, instead use qemu_coroutine_yield().
> - Use bdrv_co_is_allocated().
> - Much better SYNC_MODE_NONE test.
> 
> V3:
> 
> - A few style fixes.
> - Better commit message explaining how TOP and NONE operate.
> - Verified using checkpatch.pl.
> 
> Ian Main (2):
>   Implement sync modes for drive-backup.
>   Add tests for sync modes 'TOP' and 'NONE'
> 
>  block/backup.c                | 91 
> +++++++++++++++++++++++++++++--------------
>  blockdev.c                    | 25 ++++++++----
>  include/block/block_int.h     |  4 +-
>  qapi-schema.json              |  4 ++
>  qmp-commands.hx               |  1 +
>  tests/qemu-iotests/055        | 67 +++++++++++++++++++++++++++++--
>  tests/qemu-iotests/055.out    |  4 +-
>  tests/qemu-iotests/group      |  2 +-
>  tests/qemu-iotests/iotests.py |  5 +++
>  9 files changed, 157 insertions(+), 46 deletions(-)
> 

This still doesn't have a working NONE when used with the NBD server,
which is one of the two cases which we actually care about.

Paolo