[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: usb2 and usb3 controller
From: |
Ian Campbell |
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: usb2 and usb3 controller support for upstream qemu |
Date: |
Fri, 12 Jul 2013 10:17:05 +0100 |
On Fri, 2013-07-12 at 10:08 +0100, Wei Liu wrote:
> On Thu, Jul 11, 2013 at 12:33:57PM +0200, Fabio Fantoni wrote:
> > diff --git a/tools/libxl/xl_sxp.c b/tools/libxl/xl_sxp.c
> > index a16a025..2dc3a86 100644
> > --- a/tools/libxl/xl_sxp.c
> > +++ b/tools/libxl/xl_sxp.c
> > @@ -142,6 +142,7 @@ void printf_info_sexp(int domid, libxl_domain_config
> > *d_config)
> > printf("\t\t\t(serial %s)\n", b_info->u.hvm.serial);
> > printf("\t\t\t(boot %s)\n", b_info->u.hvm.boot);
> > printf("\t\t\t(usb %s)\n",
> > libxl_defbool_to_string(b_info->u.hvm.usb));
> > + printf("\t\t\t(usb %d)\n", b_info->u.hvm.usbversion);
>
> Should be "usbversion".
Actually this file shouldn't be patched at all. The sxp output exists
solely for compatibility with existing scripts which expect xend and so
does not need to reflect the status of new features.
Ian.