[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 13/22] PPC: dbdma: Allow new commands in RUN state
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH 13/22] PPC: dbdma: Allow new commands in RUN state |
Date: |
Thu, 11 Jul 2013 19:01:16 +0200 |
The DBDMA controller can not change its command stream while it's
actively streaming data, true. But the fact that it's in RUN state
doesn't actually indicate anything. It could just as well be in
WAIT while in RUN. And then it's legal to change commands.
This fixes a real world issue I've encountered with Mac OS X.
Signed-off-by: Alexander Graf <address@hidden>
---
hw/misc/macio/mac_dbdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/misc/macio/mac_dbdma.c b/hw/misc/macio/mac_dbdma.c
index 3b1e97e..7656767 100644
--- a/hw/misc/macio/mac_dbdma.c
+++ b/hw/misc/macio/mac_dbdma.c
@@ -725,11 +725,11 @@ static void dbdma_write(void *opaque, hwaddr addr,
DBDMA_DPRINTF("channel 0x%x reg 0x%x\n",
(uint32_t)addr >> DBDMA_CHANNEL_SHIFT, reg);
- /* cmdptr cannot be modified if channel is RUN or ACTIVE */
+ /* cmdptr cannot be modified if channel is ACTIVE */
- if (reg == DBDMA_CMDPTR_LO &&
- (ch->regs[DBDMA_STATUS] & (RUN | ACTIVE)))
+ if (reg == DBDMA_CMDPTR_LO && (ch->regs[DBDMA_STATUS] & ACTIVE)) {
return;
+ }
ch->regs[reg] = value;
--
1.8.1.4
- [Qemu-devel] [PATCH 03/22] spapr: Use named enum for function remove_hpte, (continued)
- [Qemu-devel] [PATCH 03/22] spapr: Use named enum for function remove_hpte, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 01/22] e600 core for MPC86xx processors, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 12/22] PPC: dbdma: Fix debug print, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 15/22] PPC: dbdma: Introduce kick function, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 22/22] PPC: dbdma: Support more multi-issue DMA requests, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 21/22] PPC: Add timer handler for newworld mac-io, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 17/22] PPC: dbdma: macio: Add DMA callback, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 11/22] PPC: Mac: Add debug prints in macio and dbdma code, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 18/22] PPC: dbdma: Move processing to io, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 10/22] PPC: dbdma: Replace tabs with spaces, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 13/22] PPC: dbdma: Allow new commands in RUN state,
Alexander Graf <=
- [Qemu-devel] [PATCH 16/22] PPC: dbdma: Move static bh variable to device struct, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 07/22] PPC: Mac: Fix guest exported tbfreq values, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 14/22] PPC: dbdma: Move defines into header file, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 08/22] PPC: g3beige: Move secondary IDE bus to mac-io, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 06/22] target-ppc: Add POWER8 v1.0 CPU model, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 19/22] PPC: dbdma: Wait for DMA until we have data, Alexander Graf, 2013/07/11
- [Qemu-devel] [PATCH 20/22] PPC: dbdma: Support unaligned DMA access, Alexander Graf, 2013/07/11
- Re: [Qemu-devel] [APPLIED] Merge remote-tracking branch 'agraf/ppc-for-upstream' into staging, Anthony Liguori, 2013/07/12