[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 0/5] Add infinite loop check for backing file
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V2 0/5] Add infinite loop check for backing file chain |
Date: |
Wed, 10 Jul 2013 11:20:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/10/2013 05:42 AM, Kevin Wolf wrote:
>> Thanks for the series. I made a few comments on each patch. You hashed
>> windows full path to get the "inode", but case sensitively, would that
>> work with the same files of different case?
>
> I seem to remember that Windows can be made case-sensitive. In this
> case, we must not ignore case. Not detecting some loops is okay (but here
> we would in fact detect it in the second iteration), rejecting valid
> configurations is not.
Indeed, Windows can be made case-sensitive. But you still want to hash
case-insensitive, and just be careful to not report collisions until
after checking inode equality. For that matter, stat() on windows is
notoriously lame (such as returning 0 for st_ino on FAT, regardless of
file). While I've compiled on windows, it has generally been on cygwin
(where they go to great lengths to give a sane stat() in spite of FAT's
shortcomings); you may want to get a review from someone more intimately
acquainted with mingw (Paolo?), in case there is no way to make inode
equality work, and where you may be better off with absolute path name
comparison.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V2 2/5] Add WIN32 platform support for backing_file_loop_check(), (continued)
[Qemu-devel] [PATCH V2 3/5] Check infinite loop in bdrv_img_create(), Xu Wang, 2013/07/08
[Qemu-devel] [PATCH V2 4/5] Add backing file loop check in change_backing_file(), Xu Wang, 2013/07/08
[Qemu-devel] [PATCH V2 5/5] Add infinite loop check in drive_init(), Xu Wang, 2013/07/08
Re: [Qemu-devel] [PATCH V2 0/5] Add infinite loop check for backing file chain, Fam Zheng, 2013/07/10