[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupporte
|
From: |
Peter Lieven |
|
Subject: |
Re: [Qemu-devel] [PATCHv2 10/11] iscsi: ignore aio_discard if unsupported |
|
Date: |
Wed, 10 Jul 2013 16:04:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 |
Am 10.07.2013 13:33, schrieb Kevin Wolf:
> Am 27.06.2013 um 15:11 hat Peter Lieven geschrieben:
>> if the target does not support UNMAP or the request
>> is too big silently ignore the discard request.
>>
>> Signed-off-by: Peter Lieven <address@hidden>
> Why not loop for the "too big" case? You can probably use the same logic
> for unmapping the whole device in .bdrv_create and here.
right, but looping in an aio function seemed not so trivial to me.
it seems more and more obvious to me that the best would be to change
all the remaining aio routines to co routines.
in this case i could add the too big logic in iscsi_co_discard and simply call
it from iscsi_co_write_zeroes.
Peter
>
> Kevin