[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions |
Date: |
Tue, 9 Jul 2013 10:14:39 -0400 |
On Tue, 09 Jul 2013 22:03:42 +0800
Wenchao Xia <address@hidden> wrote:
>
> >> You could pass cur_mon to readline_completion() in readline_handle_byte()
> >> to avoid all this, but it would be preferable to clarify the matter.
> >>
> >> This is also another benefit of having readline_completion() in a
> >> different patch, you can (and should!) clarify this point in the commit
> >> log along with testing results.
> >>
> > OK, I'll test multiple monitors case.
> >
> >
> >
> Do you have an example about how invoke qemu with multiple monitor?
> Do you have recommendation about the way to connect to qemu's moniotr?
> I tried pty with minicom but it seems not good, so wonder your method.
You can open telnet sessions:
-monitor tcp:0:4444,server,nowait,telnet \
-monitor tcp:0:4445,server,nowait,telnet
But note that, besides testing, I'd like to see an explanation on
the commitlog as to why dropping cur_mon doesn't brake the current
code.