[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install' |
Date: |
Mon, 08 Jul 2013 15:58:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130621 Thunderbird/17.0.7 |
On 07/05/13 19:06, Tomoki Sekiyama wrote:
> On 7/4/13 8:54 , "Paolo Bonzini" <address@hidden> wrote:
>
>> Il 03/07/2013 18:19, Tomoki Sekiyama ha scritto:
>>> On 7/3/13 11:58 , "Paolo Bonzini" <address@hidden> wrote:
>>>
>>>> Il 03/07/2013 17:49, Tomoki Sekiyama ha scritto:
>>>>> - return ga_install_service(path, log_filepath,
>>>>> fixed_state_dir);
>>>>> + if (ga_install_vss_provider()) {
>>>>> + return EXIT_FAILURE;
>>>>> + }
>>>>> + if (ga_install_service(path, log_filepath,
>>>>> fixed_state_dir)) {
>>>>> + ga_uninstall_vss_provider();
>>>>> + return EXIT_FAILURE;
>>>>> + }
>>>>> + return 0;
>>>>> } else if (strcmp(service, "uninstall") == 0) {
>>>>> + ga_uninstall_vss_provider();
>>>>> return ga_uninstall_service();
>>>>
>>>> I think this shouldn't be a hard failure. Only the freeze/thaw
>>>> commands
>>>> should fail.
>>>>
>>>> Paolo
>>>
>>> Do you mean that qemu-ga should work without qga-provider.dll etc.
>>> even if it is configured --with-vss-sdk ?
>>
>> Yes, and I'm even wondering if we should move all VSS code to a DLL
>> (provider and requestor---they are very tied to each other anyway
>> because of hEventFrozen/hEventThaw), and have qemu-ga simply look for
>> qga-provider.dll dropped into the executable directory.
>>
>> Then qemu-ga can look for it even if it is not configured --with-vss-sdk.
>
> Hm, that sounds reasonable.
>
> I will try on moving the requestor into qga-provider.dll at next
> iteration.
Is it OK with you if I skip reviewing v5 then? If the v5->v6
reorganization is going to be intrusive (ie. I won't be able to do a
patch-by-patch interdiff), then I'd prefer skipping v5.
Thanks,
Laszlo
- [Qemu-devel] [PATCH v5 02/11] Add c++ keywords to QAPI helper script, (continued)
- [Qemu-devel] [PATCH v5 02/11] Add c++ keywords to QAPI helper script, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 07/11] error: Add error_set_win32 and error_setg_win32, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 06/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 03/11] checkpatch.pl: Check .cpp files, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 08/11] qemu-ga: Add Windows VSS requester to quiesce applications and filesystems, Tomoki Sekiyama, 2013/07/03
- [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Tomoki Sekiyama, 2013/07/03
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Paolo Bonzini, 2013/07/03
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Tomoki Sekiyama, 2013/07/03
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Paolo Bonzini, 2013/07/04
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Tomoki Sekiyama, 2013/07/05
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install',
Laszlo Ersek <=
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Tomoki Sekiyama, 2013/07/08
- Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Laszlo Ersek, 2013/07/08
[Qemu-devel] [PATCH v5 09/11] qemu-ga: Call Windows VSS requester in fsfreeze command handler, Tomoki Sekiyama, 2013/07/03
[Qemu-devel] [PATCH v5 11/11] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command, Tomoki Sekiyama, 2013/07/03