[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels f
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries. |
Date: |
Mon, 08 Jul 2013 11:02:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am 08.07.2013 03:09, schrieb David Gibson:
> On Sat, Jul 06, 2013 at 11:54:15PM +1000, Alexey Kardashevskiy
> wrote:
>> @@ -1342,6 +1346,13 @@ static void
>> ppc_spapr_init(QEMUMachineInitArgs *args)
>> register_savevm_live(NULL, "spapr/htab", -1, 1,
>> &savevm_htab_handlers, spapr);
>>
>> + /* Ensure that cpu_model is correctly reflected for a KVM
>> guest */ + if (kvm_enabled() && !strcmp(cpu_model, "host")) {
>> + asm ("mfpvr %0" + : "=r"(pvr)); +
>> cpu_model = ppc_cpu_alias_by_pvr(pvr);
>
> This needs to be protected by an ifdef CONFIG_KVM or similar. If
> the compiler optimization level is turned down, so that it doesn't
> recognize that the kvm_enabled() is always false, then this could
> attempt to compile the ppc asm instructions on an x86 (or
> whatever) host.
This hunk can be completely replaced by QOM mechanisms - just didn't
get to replying yet...
Andreas
- --
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendrffer; HRB 16746 AG Nrnberg
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
iQIcBAEBAgAGBQJR2oAjAAoJEPou0S0+fgE/kxEP/2hvke1o/T4/h3Gl48W2+ASv
84iu5M7atndRF1L1bI6VogmQGlhE4qiAMxuLljpqriXz5lZndslMMcP3mx4skljD
Y3YX9Hi37yR9KEaw0AzoQCBhhS5ZIMGjd/mtW/DqPDcN0H0IdCu340Mz/Lr+0HHy
wp+ChUA8q8iYWJd6zmFmIvnaHUdbRoOHePhVlJD+GZQ2oBNu48DAaiiCdnrEJy+R
ipyZJEF+QmO2RlNDgImOKfyKry6PhuWPBIjMB3qZWyuFzmkwNEcQILnOVSW/bBIl
zXkEkWy3u5fES1+bYs1J4ZL6MZ+Edcd0c2BRKQ9JNUGM6mBj1S61aP8rC7u1VgLp
eUfkSRYOrsvVvJJ/kpOzgWgcgYnfSYp/CUTRURHxlyIxNuvhjDllRhC4wxbF4Bk4
l6jbIDa8jAMTlbCj9EW03Fi+i+oGemkOg2g5Dxl5GnFwdPC95fE39RvSa5vB3X3q
6IgdkbicFReR1dY8JxdcJsTln6b2eMTSHvUjH56FEvDQ9Z/W7TM/qc1jpmNDX7WS
bdWHcziPeAoY9Sk0aMK/LlTKmgZQM1gi5eyKIrL4ujtU3O4VKcNSihYu+Moc+oyx
pEfJrkXP6cvYLwW60yxj8soBv9ssCSBU5ZqgcSK7NlfST0KxtQe4y+jwCT0LkhyS
Qoat9lALzVlVlQwCWM6/
=2tHJ
-----END PGP SIGNATURE-----
- [Qemu-devel] [PATCH 11/19] pseries: savevm support for PAPR virtual SCSI, (continued)
- [Qemu-devel] [PATCH 11/19] pseries: savevm support for PAPR virtual SCSI, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 12/19] pseries: savevm support for pseries machine, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 13/19] pseries: savevm support for PCI host bridge, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 14/19] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 15/19] pseries: Support for in-kernel XICS interrupt controller, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 16/19] pseries: savevm support with KVM, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 17/19] target-ppc: Add POWER8 v1.0 CPU model, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries., Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH v2 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries., Prerna Saxena, 2013/07/08
[Qemu-devel] [PATCH 19/19] spapr-pci: rework MSI/MSIX, Alexey Kardashevskiy, 2013/07/06
[Qemu-devel] [PATCH 08/19] pseries: savevm support for PAPR VIO logical tty, Alexey Kardashevskiy, 2013/07/06
Re: [Qemu-devel] [PATCH 00/19 v4] spapr: migration, pci, msi, power8, Anthony Liguori, 2013/07/29