Re: [Qemu-devel] [PATCH v2 07/11] exec: check MRU in qemu_ram_addr_from_host

[Jan Kiszka]

On 2013-06-28 18:58, Paolo Bonzini wrote:
> This function is not used outside the iothread mutex, so it
> can use ram_list.mru_block.

Add a comment to qemu_ram_addr_from_host to document this requirement?

> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  exec.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index 8722420..f3d7b18 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1408,18 +1408,26 @@ int qemu_ram_addr_from_host(void *ptr, ram_addr_t 
> *ram_addr)
>          return 0;
>      }
>  
> +    block = ram_list.mru_block;
> +    if (block && block->host && host - block->host < block->length) {
> +        goto found;
> +    }
> +
>      QTAILQ_FOREACH(block, &ram_list.blocks, next) {
>          /* This case append when the block is not mapped. */
>          if (block->host == NULL) {
>              continue;
>          }
>          if (host - block->host < block->length) {
> -            *ram_addr = block->offset + (host - block->host);
> -            return 0;
> +            goto found;
>          }
>      }
>  
>      return -1;
> +
> +found:
> +    *ram_addr = block->offset + (host - block->host);
> +    return 0;
>  }
>  
>  /* Some of the softmmu routines need to translate from a host pointer
> 

Beside the nit:
Reviewed-by: Jan Kiszka <address@hidden>

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux