Re: [Qemu-devel] [PATCH v3 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

[Michael Roth]

On Mon, Jul 1, 2013 at 9:31 AM, Kevin Wolf <address@hidden> wrote:
> We don't have to duplicate the definition any more now that we may refer
> to a type instead.
>
> Signed-off-by: Kevin Wolf <address@hidden>

Reviewed-by: Michael Roth <address@hidden>

> ---
>  qapi-schema.json | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 5c32528..a90aeb1 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1709,16 +1709,7 @@
>  #
>  # Generates a synchronous snapshot of a block device.
>  #
> -# @device:  the name of the device to generate the snapshot from.
> -#
> -# @snapshot-file: the target of the new image. If the file exists, or if it
> -#                 is a device, the snapshot will be created in the existing
> -#                 file/device. If does not exist, a new file will be created.
> -#
> -# @format: #optional the format of the snapshot image, default is 'qcow2'.
> -#
> -# @mode: #optional whether and how QEMU should create a new image, default is
> -#        'absolute-paths'.
> +# For the arguments, see the documentation of BlockdevSnapshot.
>  #
>  # Returns: nothing on success
>  #          If @device is not a valid block device, DeviceNotFound
> @@ -1726,8 +1717,7 @@
>  # Since 0.14.0
>  ##
>  { 'command': 'blockdev-snapshot-sync',
> -  'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str',
> -            '*mode': 'NewImageMode'} }
> +  'data': 'BlockdevSnapshot' }
>
>  ##
>  # @human-monitor-command:
> --
> 1.8.1.4
>