[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] qemu-char: Fix ID reuse after chardev-remov
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] qemu-char: Fix ID reuse after chardev-remove for qapi-based init |
|
Date: |
Thu, 27 Jun 2013 15:33:35 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130513 Thunderbird/17.0.6 |
On 06/27/13 15:25, Markus Armbruster wrote:
> Commit 2c5f488 introduced qapi-based character device initialization
> as a new code path in qemu_chr_new_from_opts(). Unfortunately, it
> failed to store parameter opts in the new chardev. Therefore,
> qemu_chr_delete() doesn't delete it. Even though the device is gone,
> its options linger, and any attempt to create another one with the
> same ID fails.
Reviewed-by: Gerd Hoffmann <address@hidden>
cheers,
Gerd