Re: [Qemu-devel] [PATCH] hw/mips: align initrd to 64KB to avoid kernel error

[Peter Maydell]

On 27 June 2013 08:35, Leon Alrae <address@hidden> wrote:
> From: James Hogan <address@hidden>
>
> The Linux kernel can be configured to use 64KB pages, but it also
> requires initrd to be page aligned. Therefore, to be safe, align the
> initrd to 64KB using a new INITRD_PAGE_MASK rather than
> TARGET_PAGE_MASK.

This is kind of similar to the ARM bug fixed in 98ed805c3.
I wonder if we ought to have a per-CPU #define for "largest
possible page alignment for this architecture" as well as
"smallest possible" (the latter being TARGET_PAGE_MASK).

This patch is a reasonable enough way to fix things though,
so I'm not objecting to it.

Aside: given the repetitive nature of the context hunks
observable in this patch, it looks like it ought to be
possible to abstract out some of the initrd/kernel load
code from all those boards...

thanks
-- PMM