[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and ch
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition |
Date: |
Tue, 25 Jun 2013 15:53:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 25/06/2013 15:44, Michael R. Hines ha scritto:
>>>
>> I don't like the three-arguments migrate_set_state, but I don't have any
>> better idea.
>>
>> With Juan's modification, it is fine (but not reviewed-by me :)). While
>> you resend, the first 13 patches of v10 can be merged (pull request).
>> You can then rebase the last three on top.
>
> So, I should send a v11 before Juan applies and generates the pull request?
>
> Did I understand correctly?
Juan found another small nit, so please do send a v12. He liked (with
the small change in cancellation) your last three patches, so there is
no need to split out patch 13 (as you had it in v10).
>> Michael, did you look at the "debugging/getting the protocol ready" mode
>> where all pages are unpinned?
>
> We did not come up with a design on how such a mode would be
> exposed to the user. Implementing this in migration-rdma.c is
> just a few lines of code, but without a clear use case in this patch
> series, I've not chosen expose it to the user yet without some kind
> of agreement with you guys.
Do those few lines of code change the protocol? If yes, I'll go against
all my previous recommendations and suggest a #define. If no, it is
fine to leave it for later, but I would still suggest posting the patch
on the list just for information.
Paolo
- [Qemu-devel] [PATCH v11 04/15] rdma: export throughput w/ MigrationStats QMP, (continued)
- [Qemu-devel] [PATCH v11 04/15] rdma: export throughput w/ MigrationStats QMP, mrhines, 2013/06/24
- [Qemu-devel] [PATCH v11 12/15] rdma: send pc.ram, mrhines, 2013/06/24
- [Qemu-devel] [PATCH v11 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP, mrhines, 2013/06/24
- [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, mrhines, 2013/06/24
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Juan Quintela, 2013/06/25
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Paolo Bonzini, 2013/06/25
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Michael R. Hines, 2013/06/25
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Michael R. Hines, 2013/06/25
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Paolo Bonzini, 2013/06/25
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Michael R. Hines, 2013/06/25
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Michael R. Hines, 2013/06/25
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Paolo Bonzini, 2013/06/25
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Michael R. Hines, 2013/06/25
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Paolo Bonzini, 2013/06/26
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Michael R. Hines, 2013/06/26
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Paolo Bonzini, 2013/06/26
- Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition, Michael R. Hines, 2013/06/26