Re: [Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

[Stefan Hajnoczi]

On Fri, Jun 21, 2013 at 06:37:18PM -0700, Ronnie Sahlberg wrote:

Looks fine except these whitespace issues:

> @@ -727,14 +730,36 @@ static BlockDriverAIOCB 
> *iscsi_aio_ioctl(BlockDriverState *bs,
>      memcpy(&acb->task->cdb[0], acb->ioh->cmdp, acb->ioh->cmd_len);
>      acb->task->expxferlen = acb->ioh->dxfer_len;
>  
> +    data.size = 0;
>      if (acb->task->xfer_dir == SCSI_XFER_WRITE) {
> -        data.data = acb->ioh->dxferp;
> -        data.size = acb->ioh->dxfer_len;
> +        if (acb->ioh->iovec_count == 0) {
> +            data.data = acb->ioh->dxferp;
> +            data.size = acb->ioh->dxfer_len;
> +        } else {
> +#if defined(LIBISCSI_FEATURE_IOVECTOR)
> +             scsi_task_set_iov_out(acb->task,

Indentation should be 4 spaces.

> +                                  (struct scsi_iovec *) acb->ioh->dxferp,
> +                                  acb->ioh->iovec_count);
> + #else

Space before #else?