[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] multiboot: Fix memory information
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] multiboot: Fix memory information |
Date: |
Mon, 24 Jun 2013 10:02:42 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 23.06.2013 um 23:39 hat Anthony Liguori geschrieben:
> Kevin Wolf <address@hidden> writes:
>
> > Kevin Wolf (3):
> > multiboot: Don't forget last mmap entry
> > multiboot: Calculate upper_mem in the ROM
> > multiboot: Updated ROM binary
>
> Reviewed-by: Anthony Liguori <address@hidden>
>
> Do you have a test case that triggered this that you can share?
I haven't seen an actual kernel failure myself, this was reported by
someone else. But it's easy enough to check with a simple Multiboot
kernel that just outputs lower_mem/upper_mem and the mmap.
For debugging and fixing I added some throw-away debug code to an
existing kernel and compared the fixed version with the output when
loaded by GRUB and it matches now.
If we can have a real test case for this somewhere, I can write a small
kernel to do the check. Not sure where it would fit though - probably
kvm-unittests is the closest, even though the test wouldn't really have
anything to do with KVM.
> I'll apply this after a day or so when others have had a chance to review.
Sounds good, thanks.
Kevin