qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-trivial] [PATCH 00/13] A bunch of little socket +


From: Michael Tokarev
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 00/13] A bunch of little socket + chardev fixes
Date: Fri, 21 Jun 2013 22:47:28 +0400
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130529 Icedove/17.0.5

21.06.2013 14:38, Gerd Hoffmann wrote:
>   Hi,
> 
> Here is a colletion of little bugfixes and minor improvements for the
> chardev and socket code.

Thank you Gerd!  You had me busy for some time verifying it all ;)

The series looks fine, except:

> Gerd Hoffmann (13):
>   qemu-socket: zero-initialize SocketAddress

Maybe we should drop the =NULL initializer as well, suggested
patch included.

>   qemu-socket: drop pointless allocation
>   qemu-socket: catch monitor_get_fd failures

A nitpick, suggested patch included.

>   qemu-char: check optional fields using has_*
>   qemu-char: use more specific error_setg_* variants
>   qemu-char: print notification to stderr
>   qemu-char: fix documentation for telnet+wait socket flags
>   qemu-char: don't leak opts on error
>   qemu-char: use ChardevBackendKind in in CharDriver

In other place int is used instead of this type.
(sysemu/sysemu.h where the prototype is declared
#includes qapi-types.h)

>   qemu-char: minor mux chardev fixes
>   qemu-char: add -chardev mux support
>   qemu-char: report udb backend errors

syntax error in the description, I can fix that when applying

>   qemu-socket: don't leak opts on error

Looks good.  I can fix all the above if you want :)

Thanks!

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]