Re: [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg in I/O space

[Markus Armbruster]

Markus Armbruster <address@hidden> writes:

> Anthony Liguori <address@hidden> writes:
>
>> Markus Armbruster <address@hidden> writes:
>>
>>> Next commit needs it.
>>>
>>> Cc: Blue Swirl <address@hidden>
>>> Signed-off-by: Markus Armbruster <address@hidden>
>>> ---
>>>  tests/boot-order-test.c | 24 ++++++++++++++++--------
>>>  1 file changed, 16 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c
>>> index 7b1edc1..d1d99f8 100644
>>> --- a/tests/boot-order-test.c
>>> +++ b/tests/boot-order-test.c
>>> @@ -133,23 +133,31 @@ static void test_prep_boot_order(void)
>>>      test_boot_orders("prep", read_boot_order_prep, test_cases_prep);
>>>  }
>>>  
>>> -static void read_fw_cfg(uint64_t cfg_addr, uint16_t cmd,
>>> +static void read_fw_cfg(uint64_t cfg_addr, bool addr_is_io, uint16_t cmd,
>>>                          void *buf, size_t len)
>>
>> I missed it earlier, but you can use libqos/fw_cfg.h for this.
>
> Missed on rebase, thanks for pointing it out.
>
> Two options:
>
> (1) You commit this minor code duplication now, and I promise to clean
>     it up in a follow-up series.
>
> (2) You tell me to rework this series so it uses libqos/fw_cfg.h from
>     the start.
>
> I'd prefer (1).

(3) Commit PATCH 01-06/16 now (which passed your review), bounce the
rest back to me.

Still prefer (1), though :)