Re: [Qemu-devel] [PATCH v4 04/12] ARM: Add AArch64 translation stub

[Peter Maydell]

On 16 June 2013 21:06, Andreas Färber <address@hidden> wrote:
> My qom-cpu-10 series may help here, it turns cpu_dump_state() into a
> simple helper function calling CPUClass::dump_state(). So a Cortex-A5x
> class_init or TARGET_AARCH64 for the base class_init would simply assign
> the 64-bit version of the callback, leaving 32-bit target unaffected
> (note: I didn't read the whole patch).

Yeah, that would work and be neater than ifdeffery. (the 64 bit
callback would then have to call the 32 bit callback if we're
really in 32 bit mode, but that's not a problem). In the meantime if
this lands before your series it's easy enough to just have an ifdef
that makes cpu_dump_state_a64() a no-op if building the 32 bit binary.
(in fact that's what my current working tree has.)

thanks
-- PMM