Re: [Qemu-devel] [PATCH qom-cpu 31/59] monitor: Simplify do_info_numa()

[Andreas Färber]

Am 11.06.2013 09:41, schrieb Markus Armbruster:
> Andreas Färber <address@hidden> writes:
>> If having patch 57/59 larger is not a concern (which getting rid of
>> open-coded CPU loops tried to address), then I can just convert the
>> loops in place alongside first_cpu / next_cpu.
>> Then still the question remains of whether you'd want to inline and drop
>> qemu_for_each_cpu() afterwards, or whether we can establish some rules
>> of thumb when to use which?
> 
> To be honest, I see no value in qemu_for_each_cpu().
> 
> At a glance, PATCH 57 looks fairly mechanical to me.  Is it?  Would it
> remain so if refrains from converting simple loops to
> qemu_for_each_cpu()?

v2 does that now.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg