[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit abo
From: |
Bharat Bhushan |
Subject: |
[Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61 |
Date: |
Mon, 10 Jun 2013 13:25:18 +0530 |
QEMU timer supports a maximum timer of INT64_MAX. So starting timer only for
time which is calculated using target_bit < 62 and deactivate/stop timer if
the target bit is above 61.
This patch also fix the time calculation from target_bit.
The code was doing (1 << (target_bit + 1)) while this
should be (1ULL << (target_bit + 1)).
Signed-off-by: Bharat Bhushan <address@hidden>
---
v1->v2
- Added "booke: timer:" in patch subject
hw/ppc/ppc_booke.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c
index e41b036..f4eda15 100644
--- a/hw/ppc/ppc_booke.c
+++ b/hw/ppc/ppc_booke.c
@@ -133,9 +133,15 @@ static void booke_update_fixed_timer(CPUPPCState
*env,
ppc_tb_t *tb_env = env->tb_env;
uint64_t lapse;
uint64_t tb;
- uint64_t period = 1 << (target_bit + 1);
+ uint64_t period;
uint64_t now;
+ /* Deactivate timer for target_bit > 61 */
+ if (target_bit > 61)
+ return;
+
+ period = 1ULL << (target_bit + 1);
+
now = qemu_get_clock_ns(vm_clock);
tb = cpu_ppc_get_tb(tb_env, now, tb_env->tb_offset);
--
1.7.0.4
- [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61,
Bharat Bhushan <=
- Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61, Peter Maydell, 2013/06/10
- Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61, Andreas Färber, 2013/06/10
- Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61, Bhushan Bharat-R65777, 2013/06/10
- Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61, Alexander Graf, 2013/06/10
- Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61, Scott Wood, 2013/06/10
- Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61, Alexander Graf, 2013/06/10
- Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61, Bhushan Bharat-R65777, 2013/06/11
- Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61, Alexander Graf, 2013/06/11
- Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61, Bhushan Bharat-R65777, 2013/06/11