Re: [Qemu-devel] [PATCH v2 05/12] kvm/i8254: QOM'ify some more

[li guang]

在 2013-06-10一的 03:40 +0200，Andreas Färber写道：
> Am 10.06.2013 03:37, schrieb li guang:
> > 在 2013-06-07五的 14:58 +0200，Andreas Färber写道：
> >> diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c
> >> index da90711..4ac5551 100644
> >> --- a/hw/i386/kvm/i8254.c
> >> +++ b/hw/i386/kvm/i8254.c
> [...]
> >> @@ -70,7 +73,7 @@ static void kvm_pit_update_clock_offset(KVMPITState *s)
> >>  
> >>  static void kvm_pit_get(PITCommonState *pit)
> >>  {
> >> -    KVMPITState *s = DO_UPCAST(KVMPITState, pit, pit);
> >> +    KVMPITState *s = KVM_PIT(pit);
> > 
> > maybe we should keep the coding-style
> > either func(...) or func (...),
> > these patches blend them.
> 
> Where exactly? Only malc's audio files should have the func (...) style.
> 

patch 2,3