[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/12] kvm/i8254: QOM'ify some more
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/12] kvm/i8254: QOM'ify some more |
Date: |
Mon, 10 Jun 2013 03:40:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 10.06.2013 03:37, schrieb li guang:
> 在 2013-06-07五的 14:58 +0200,Andreas Färber写道:
>> diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c
>> index da90711..4ac5551 100644
>> --- a/hw/i386/kvm/i8254.c
>> +++ b/hw/i386/kvm/i8254.c
[...]
>> @@ -70,7 +73,7 @@ static void kvm_pit_update_clock_offset(KVMPITState *s)
>>
>> static void kvm_pit_get(PITCommonState *pit)
>> {
>> - KVMPITState *s = DO_UPCAST(KVMPITState, pit, pit);
>> + KVMPITState *s = KVM_PIT(pit);
>
> maybe we should keep the coding-style
> either func(...) or func (...),
> these patches blend them.
Where exactly? Only malc's audio files should have the func (...) style.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v2 01/12] gus: QOM'ify some more, (continued)
- [Qemu-devel] [PATCH v2 01/12] gus: QOM'ify some more, Andreas Färber, 2013/06/07
- [Qemu-devel] [PATCH v2 09/12] i8259: Convert PICCommonState to use QOM realizefn, Andreas Färber, 2013/06/07
- [Qemu-devel] [PATCH v2 10/12] isa: QOM'ify ISABus, Andreas Färber, 2013/06/07
- [Qemu-devel] [PATCH v2 12/12] qdev: Drop FROM_QBUS() macro, Andreas Färber, 2013/06/07
- [Qemu-devel] [PATCH v2 11/12] isa: QOM'ify ISADevice, Andreas Färber, 2013/06/07
- [Qemu-devel] [PATCH v2 08/12] kvm/i8259: QOM'ify some more, Andreas Färber, 2013/06/07
- [Qemu-devel] [PATCH v2 02/12] cs4231a: QOM'ify some more, Andreas Färber, 2013/06/07
- [Qemu-devel] [PATCH v2 07/12] i8259: QOM'ify some more, Andreas Färber, 2013/06/07
- [Qemu-devel] [PATCH v2 05/12] kvm/i8254: QOM'ify some more, Andreas Färber, 2013/06/07
- [Qemu-devel] [PATCH v2 06/12] i8254: Convert PITCommonState to QOM realizefn, Andreas Färber, 2013/06/07
- [Qemu-devel] [PATCH v2 03/12] isa: Use realizefn for ISADevice, Andreas Färber, 2013/06/07
- Re: [Qemu-devel] [PATCH v2 00/12] QOM realize for ISA, part 2, Andreas Färber, 2013/06/07
- Re: [Qemu-devel] [PATCH v2 00/12] QOM realize for ISA, part 2, Blue Swirl, 2013/06/15